WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
242842
There should be a way to indicate that PR should not close a bug
https://bugs.webkit.org/show_bug.cgi?id=242842
Summary
There should be a way to indicate that PR should not close a bug
Ryosuke Niwa
Reported
2022-07-16 21:32:42 PDT
When landing test expectation changes, etc... in GitHub, there should be a label to indicate that merge-queue / unsafe-merge-queue should not close the Bugzilla bug.
Attachments
Add attachment
proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1
2022-07-18 17:51:44 PDT
I think that such mechanism exists and is used by bot watchers, but I don't know what it is.
Fujii Hironori
Comment 2
2022-07-18 21:11:28 PDT
See
Bug#239604
Ryosuke Niwa
Comment 3
2022-07-18 21:30:02 PDT
lol, it looks for the substring "Unreviewed test gardening":
https://github.com/WebKit/WebKit/commit/253a62f8ead480bd1f0683cace622b2ebc1231cd
Alexey Proskuryakov
Comment 4
2022-07-19 09:23:16 PDT
Is this just a dupe of
bug 239604
at this point, or are you looking for a different solution?
Ryosuke Niwa
Comment 5
2022-07-19 11:23:30 PDT
(In reply to Alexey Proskuryakov from
comment #4
)
> Is this just a dupe of
bug 239604
at this point, or are you looking for a > different solution?
I don't think special casing test gardening makes sense. We need the equivalent of --no-close for git-webkit.
Radar WebKit Bug Importer
Comment 6
2022-07-23 21:33:16 PDT
<
rdar://problem/97502232
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug