NEW241635
[GitHub] Style checker should be able to comment on the diff 
https://bugs.webkit.org/show_bug.cgi?id=241635
Summary [GitHub] Style checker should be able to comment on the diff
Keith Miller
Reported 2022-06-15 09:04:36 PDT
Right now there is the merge (not sure exactly what the name is) check for style. But reviewers still need to click on the details page to see if any are relevant. It could be useful to provide a button next to the details link that will have the style checker comment on the lines it thinks have issues. We may not want this all the time because it could become quite noisy, which happened back in the day on bugzilla. Thus, a button or some other user initiated trigger would be my recommendation.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-06-22 09:05:13 PDT
<rdar://problem/95695974>
Sam Sneddon [:gsnedders]
Comment 2 2024-11-25 07:39:19 PST
Potentially we'd could create a check run and then we could actually leave annotations (which appear similar to review comments) for style check failures. However, that requires us to be using a GitHub App to interact with GitHub, which I don't believe we do currently? See: https://docs.github.com/en/rest/checks/runs?apiVersion=2022-11-28#:~:text=annotations,-array%20of%20objects If we're concerned about noisiness, we could either require a button to be clicked in the GitHub check UI, or add some sort of bot command in a comment on the PR. That said, https://ews-build.webkit.org/#/builders/38 does look like it passes on the overwhelming majority of EWS runs.
Note You need to log in before you can comment on or make changes to this bug.