RESOLVED FIXED248424
imported/w3c/web-platform-tests/fetch/stale-while-revalidate/revalidate-not-blocked-by-csp.html times out 
https://bugs.webkit.org/show_bug.cgi?id=248424
Summary imported/w3c/web-platform-tests/fetch/stale-while-revalidate/revalidate-not-b...
Ryan Reno
Reported 2022-11-28 14:20:56 PST
This test times out waiting for the server to return a Count header with a value of 2. It's stuck sending back 1. Could be a bug in the python that acts as a server and not necessarily in WebKit itself. All browsers fail this test (and all stale-while-revalidate tests) on WPT.
Attachments
Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2022-11-28 14:21:21 PST
<rdar://problem/102734100>
Ryan Reno
Comment 2 2022-11-28 15:04:31 PST
Fix for this is pretty simple. The Python server only increments the count when there isn't a `query` parameter in the request. The initial fetch to get the image incremented the counter to 1 but in the test's "wait for revalidate" loop we always called fetch with the `query` URL parameter. This caused the server to never increment count. I added a boolean which we flip every other loop. This boolean determines whether or not we add `query` to the URL and in turn whether or not the server will increment the count.
Ryan Reno
Comment 3 2022-11-28 15:47:01 PST
Pull request: https://github.com/WebKit/WebKit/pull/6893
Ryan Reno
Comment 4 2022-11-28 15:48:00 PST
Submitted web-platform-tests pull request: https://github.com/web-platform-tests/wpt/pull/37213
EWS
Comment 5 2022-11-29 18:21:13 PST
Committed 257154@main (ee768c0b2c58): <https://commits.webkit.org/257154@main> Reviewed commits have been landed. Closing PR #6893 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.