Bug 94418

Summary: Refactor SVGMaskElement to inherit from StyledElement
Product: WebKit Reporter: Philip Rogers <pdr>
Component: SVGAssignee: Philip Rogers <pdr>
Status: RESOLVED FIXED    
Severity: Normal CC: krit, webkit.review.bot, zimmermann
Priority: P2    
Version: 420+   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Refactor SVGMaskElement to inherit from StyledElement none

Philip Rogers
Reported 2012-08-18 15:08:27 PDT
SVGMaskElement is a subclass of SVGStyledLocatableElement but it should be a subclass of SVGStyledElement. Spec: http://www.w3.org/TR/SVG/single-page.html#masking-InterfaceSVGMaskElement
Attachments
Refactor SVGMaskElement to inherit from StyledElement (2.79 KB, patch)
2012-08-18 15:12 PDT, Philip Rogers 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Philip Rogers
Comment 1 2012-08-18 15:12:56 PDT
Created attachment 159271 [details] Refactor SVGMaskElement to inherit from StyledElement
Dirk Schulze
Comment 2 2012-08-18 17:06:49 PDT
Don't spend to much Time in refactoring. The structure will change with SVG2 completely.
WebKit Review Bot
Comment 3 2012-08-18 17:57:54 PDT
Comment on attachment 159271 [details] Refactor SVGMaskElement to inherit from StyledElement Clearing flags on attachment: 159271 Committed r125971: <http://trac.webkit.org/changeset/125971>
WebKit Review Bot
Comment 4 2012-08-18 17:57:57 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.