Bug 86023

Summary: echo-inspan.pl is missing a semicolon on line 14, freaks out Apache on multiple regression tests
Product: WebKit Reporter: WebKit Review Bot <webkit.review.bot>
Component: Tools / TestsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, dbates, dglazkov, eric, tsepez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric: review+, webkit.review.bot: commit-queue-
Archive of layout-test-results from ec2-cq-02
none
Archive of layout-test-results from ec2-cr-linux-04
none
Patch and rebase tests
none
Patch and rebased tests none

WebKit Review Bot
Reported 2012-05-09 15:28:33 PDT
echo-inspan.pl is missing a ; on like 14 Requested by abarth on #webkit.
Attachments
Patch (1.42 KB, patch)
2012-05-22 11:20 PDT, Adam Barth 		eric: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from ec2-cq-02 (528.65 KB, application/zip)
2012-05-22 11:49 PDT, WebKit Review Bot 		no flags
Details
Archive of layout-test-results from ec2-cr-linux-04 (718.44 KB, application/zip)
2012-05-22 11:51 PDT, WebKit Review Bot 		no flags
Details
Patch and rebase tests (2.60 KB, patch)
2012-05-22 12:05 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Patch and rebased tests (2.77 KB, patch)
2012-05-22 12:07 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2012-05-22 10:25:08 PDT
Are we losing a substantial amount of coverage due to this?
Adam Barth
Comment 2 2012-05-22 11:16:43 PDT
I'm not sure. I've got a free working copy now, so I'll try to work up a patch.
Adam Barth
Comment 3 2012-05-22 11:20:13 PDT
Created attachment 143330 [details] Patch
Eric Seidel (no email)
Comment 4 2012-05-22 11:22:35 PDT
Comment on attachment 143330 [details] Patch OK.
WebKit Review Bot
Comment 5 2012-05-22 11:49:45 PDT
Comment on attachment 143330 [details] Patch Rejecting attachment 143330 [details] from commit-queue. New failing tests: http/tests/security/xssAuditor/open-script-src.html http/tests/security/xssAuditor/open-iframe-src.html Full output: http://queues.webkit.org/results/12749394
WebKit Review Bot
Comment 6 2012-05-22 11:49:49 PDT
Created attachment 143340 [details] Archive of layout-test-results from ec2-cq-02 The attached test failures were seen while running run-webkit-tests on the commit-queue. Bot: ec2-cq-02 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
WebKit Review Bot
Comment 7 2012-05-22 11:51:24 PDT
Comment on attachment 143330 [details] Patch Attachment 143330 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/12760133 New failing tests: http/tests/security/xssAuditor/open-script-src.html http/tests/security/xssAuditor/open-iframe-src.html
WebKit Review Bot
Comment 8 2012-05-22 11:51:29 PDT
Created attachment 143341 [details] Archive of layout-test-results from ec2-cr-linux-04 The attached test failures were seen while running run-webkit-tests on the chromium-ews. Bot: ec2-cr-linux-04 Port: <class 'webkitpy.common.config.ports.ChromiumXVFBPort'> Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Daniel Bates
Comment 9 2012-05-22 12:05:23 PDT
Created attachment 143344 [details] Patch and rebase tests Rebased test results for tests LayoutTests/http/tests/security/xssAuditor/{open-iframe-src, open-script-src}.html
Adam Barth
Comment 10 2012-05-22 12:06:28 PDT
dbates++
Daniel Bates
Comment 11 2012-05-22 12:07:52 PDT
Created attachment 143346 [details] Patch and rebased tests
WebKit Review Bot
Comment 12 2012-05-22 13:53:19 PDT
Comment on attachment 143346 [details] Patch and rebased tests Clearing flags on attachment: 143346 Committed r118047: <http://trac.webkit.org/changeset/118047>
WebKit Review Bot
Comment 13 2012-05-22 13:53:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.