Bug 63193

Summary: convert editing/deleting/delete-select-all-00* to dumpAsText
Product: WebKit Reporter: Wyatt Carss <wcarss>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Enhancement CC: jparent, rniwa, sullivan, wcarss, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Wyatt Carss
Reported 2011-06-22 15:31:47 PDT
convert editing/deleting/delete-select-all-00* to dumpAsText
Attachments
Patch (45.66 KB, patch)
2011-06-22 15:34 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Patch (23.77 KB, patch)
2011-06-22 23:02 PDT, Wyatt Carss 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Wyatt Carss
Comment 1 2011-06-22 15:34:46 PDT
Created attachment 98252 [details] Patch
Ryosuke Niwa
Comment 2 2011-06-22 19:22:03 PDT
Comment on attachment 98252 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98252&action=review > LayoutTests/editing/deleting/delete-select-all-002-expected.txt:1 > + We should have editing delegates. > LayoutTests/editing/deleting/delete-select-all-002.html:45 > -runEditingTest(); > +runDumpAsTextEditingTest(); You can do that by passing "true" to runDumpAsTextEditingTest.
Wyatt Carss
Comment 3 2011-06-22 23:02:53 PDT
Created attachment 98316 [details] Patch
Wyatt Carss
Comment 4 2011-06-22 23:11:58 PDT
Adding delegates makes life awful with git, because it raises the number of lines in common between the new baselines and the old ones, which causes git (with its wacky renaming philosophy) to think I've renamed files instead of deleting some and adding some others. Also, shouldn't delete-select-all-001 show delegates too?
Ryosuke Niwa
Comment 5 2011-06-23 14:52:07 PDT
Note that you can add cq? when you uploaded your patch. Then reviewer will r+ and cq+ simultaneously.
WebKit Review Bot
Comment 6 2011-06-23 15:09:57 PDT
The commit-queue encountered the following flaky tests while processing attachment 98316 [details]: http/tests/local/fileapi/file-last-modified.html bug 63294 (author: jianli@chromium.org) The commit-queue is continuing to process your patch.
WebKit Review Bot
Comment 7 2011-06-23 15:12:03 PDT
Comment on attachment 98316 [details] Patch Clearing flags on attachment: 98316 Committed r89623: <http://trac.webkit.org/changeset/89623>
WebKit Review Bot
Comment 8 2011-06-23 15:12:08 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.