Bug 176581

Summary: WSL should support while loops
Product: WebKit Reporter: Myles C. Maxfield <mmaxfield>
Component: New BugsAssignee: Myles C. Maxfield <mmaxfield>
Status: RESOLVED FIXED    
Severity: Normal CC: fpizlo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 176199    
Attachments:
Description Flags
WIP
none
WIP
none
WIP
none
Patch
none
Patch
none
Patch fpizlo: review+

Myles C. Maxfield
Reported 2017-09-07 20:57:59 PDT
WSL should support while loops
Attachments
WIP (16.94 KB, patch)
2017-09-07 20:58 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (19.22 KB, patch)
2017-09-08 00:02 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
WIP (22.94 KB, patch)
2017-09-08 11:25 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (39.58 KB, patch)
2017-09-10 16:51 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (38.82 KB, patch)
2017-09-10 17:17 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (44.90 KB, patch)
2017-09-10 17:37 PDT, Myles C. Maxfield 		fpizlo: review+
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2017-09-07 20:58:36 PDT
Created attachment 320230 [details] WIP
Myles C. Maxfield
Comment 2 2017-09-08 00:02:01 PDT
Created attachment 320246 [details] WIP
Myles C. Maxfield
Comment 3 2017-09-08 00:03:17 PDT
Comment on attachment 320246 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=320246&action=review > Tools/WebGPUShadingLanguageRI/Node.js:40 > + //memoTable.set(this, returnValue); Because Evaluator is a Visitor, the memo table doesn't work when evaluating, because while loops' conditions need to actually be evaluated each time. Fil: Do you know a way to solve this?
Myles C. Maxfield
Comment 4 2017-09-08 11:25:20 PDT
Created attachment 320285 [details] WIP
Myles C. Maxfield
Comment 5 2017-09-10 16:51:18 PDT
Created attachment 320406 [details] Patch
Myles C. Maxfield
Comment 6 2017-09-10 17:17:47 PDT
Created attachment 320408 [details] Patch
Myles C. Maxfield
Comment 7 2017-09-10 17:37:05 PDT
Created attachment 320409 [details] Patch
Filip Pizlo
Comment 8 2017-09-10 17:57:07 PDT
Comment on attachment 320409 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=320409&action=review Nice! R=me. > Tools/WebGPUShadingLanguageRI/Break.js:38 > + return "Break"; Lowercase is better since that’s what te language does. > Tools/WebGPUShadingLanguageRI/Checker.js:245 > + throw new Error("Trying to negate something with no type: " + node.conditional); I don’t think negation is what is going on here.
Myles C. Maxfield
Comment 9 2017-09-10 18:05:25 PDT
Committed r221842: <http://trac.webkit.org/changeset/221842>
Myles C. Maxfield
Comment 10 2017-09-13 21:15:21 PDT
*** Bug 176263 has been marked as a duplicate of this bug. ***
Radar WebKit Bug Importer
Comment 11 2017-09-27 12:37:01 PDT
<rdar://problem/34693608>
Myles C. Maxfield
Comment 12 2018-10-13 16:53:55 PDT
Migrated to https://github.com/gpuweb/WHLSL/issues/146
Note You need to log in before you can comment on or make changes to this bug.