Bug 167942

Summary:

Add kUTTypeUTF8PlainText and kUTTypeJPEG to the list of compatible content types in DragData

Product:

WebKit

Reporter:

Wenson Hsieh <wenson_hsieh>

Component:

WebKit Misc.

Assignee:

Wenson Hsieh <wenson_hsieh>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, sam, thorton, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Build fix	none
Move ivars to interface declaration.	thorton: review+
Patch for landing	none

Wenson Hsieh

Reported 2017-02-07 09:34:01 PST

<rdar://problem/30315079>

Attachments
Patch (1.62 KB, patch) 2017-02-07 09:38 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (3.32 KB, patch) 2017-02-07 23:00 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Patch (20.46 KB, patch) 2017-02-08 13:18 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Build fix (20.37 KB, patch) 2017-02-08 13:23 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Move ivars to interface declaration. (20.48 KB, patch) 2017-02-08 14:08 PST, Wenson Hsieh	thorton: review+	Details Formatted Diff Diff
Patch for landing (20.30 KB, patch) 2017-02-08 14:54 PST, Wenson Hsieh	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Wenson Hsieh

Comment 1 2017-02-07 09:38:42 PST

Created attachment 300815 [details] Patch

Sam Weinig

Comment 2 2017-02-07 09:59:34 PST

Comment on attachment 300815 [details] Patch Is this really only needed under ENABLE(DATA_INTERACTION)?

Wenson Hsieh

Comment 3 2017-02-07 10:01:01 PST

(In reply to comment #2) > Comment on attachment 300815 [details] > Patch > > Is this really only needed under ENABLE(DATA_INTERACTION)? I believe so. In Pasteboard::read (in PasteboardMac.mm) we don't seem to support reading these types.

Sam Weinig

Comment 4 2017-02-07 14:08:00 PST

(In reply to comment #3) > (In reply to comment #2) > > Comment on attachment 300815 [details] > > Patch > > > > Is this really only needed under ENABLE(DATA_INTERACTION)? > > I believe so. In Pasteboard::read (in PasteboardMac.mm) we don't seem to > support reading these types. Should we? Is there a good reason to support different types?

Wenson Hsieh

Comment 5 2017-02-07 23:00:28 PST

Created attachment 300881 [details] Patch

Wenson Hsieh

Comment 6 2017-02-07 23:05:06 PST

I have progress on test cases in TestWebKitAPI that use an NSView that vends only a certain UTI type (in this case, UTF8 or JPEG) when dragging. The test attempts to drag from this NSView into a web view and observe the inserted contents, but sending mouse dragged events isn't resulting in any dragging taking place for some reason. Into AppKit to find out why...

Wenson Hsieh

Comment 7 2017-02-08 13:18:38 PST

Created attachment 300949 [details] Patch

Wenson Hsieh

Comment 8 2017-02-08 13:23:33 PST

Created attachment 300951 [details] Build fix

Wenson Hsieh

Comment 9 2017-02-08 14:08:57 PST

Created attachment 300958 [details] Move ivars to interface declaration.

Tim Horton

Comment 10 2017-02-08 14:20:31 PST

Comment on attachment 300958 [details] Move ivars to interface declaration. View in context: https://bugs.webkit.org/attachment.cgi?id=300958&action=review > Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:36 > + dispatch_block_t _completionBlock; No BlockPtr love? > Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:223 > + [hostWindow setFrameOrigin:NSMakePoint(0, 0)]; Is this on-screen? We probably don't want that. Does it have to be?

Wenson Hsieh

Comment 11 2017-02-08 14:54:24 PST

Created attachment 300970 [details] Patch for landing

Wenson Hsieh

Comment 12 2017-02-08 15:18:26 PST

(In reply to comment #10) > Comment on attachment 300958 [details] > Move ivars to interface declaration. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=300958&action=review > > > Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:36 > > + dispatch_block_t _completionBlock; > > No BlockPtr love? Changed to use BlockPtr :) > > > Tools/TestWebKitAPI/Tests/mac/DragAndDropPasteboardTests.mm:223 > > + [hostWindow setFrameOrigin:NSMakePoint(0, 0)]; > > Is this on-screen? We probably don't want that. Does it have to be? Good point -- removed setVisible: and makeKeyAndOrderFront: -- it no longer appears on screen. Thanks!

WebKit Commit Bot

Comment 13 2017-02-08 15:32:25 PST

Comment on attachment 300970 [details] Patch for landing Clearing flags on attachment: 300970 Committed r211906: <http://trac.webkit.org/changeset/211906>

Note You need to log in before you can comment on or make changes to this bug.