Bug 141069

Summary: Optimize MemoryCache::getSessionMap() a bit
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: Page LoadingAssignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: ap, benjamin, commit-queue, darin, japhet, kling, koivisto, mhock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 141091    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2015-01-29 22:34:52 PST
Optimize MemoryCache::getSessionMap() a bit
Attachments
Patch (5.22 KB, patch)
2015-01-29 22:38 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.89 KB, patch)
2015-01-30 14:47 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.94 KB, patch)
2015-01-30 16:15 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.94 KB, patch)
2015-01-30 16:45 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2015-01-29 22:38:06 PST
Created attachment 245696 [details] Patch
Anders Carlsson
Comment 2 2015-01-30 07:19:11 PST
Comment on attachment 245696 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=245696&action=review > Source/WebCore/loader/cache/MemoryCache.cpp:80 > + std::unique_ptr<CachedResourceMap>& map = m_sessionResources.add(sessionID, nullptr).iterator->value; auto& map = > Source/WebCore/loader/cache/MemoryCache.h:187 > - CachedResourceMap& getSessionMap(SessionID); > + CachedResourceMap& sessionResources(SessionID = SessionID::defaultSessionID()); I think it's better to be explicit about which session we want here, otherwise it's easy to always use the default session.
Chris Dumez
Comment 3 2015-01-30 09:43:41 PST
Committed r179403: <http://trac.webkit.org/changeset/179403>
WebKit Commit Bot
Comment 5 2015-01-30 12:42:06 PST
Re-opened since this is blocked by bug 141091
Chris Dumez
Comment 6 2015-01-30 14:02:08 PST
Rolled out in <http://trac.webkit.org/changeset/179410>. I'll propose another fix.
Chris Dumez
Comment 7 2015-01-30 14:47:13 PST
Created attachment 245746 [details] Patch
Chris Dumez
Comment 8 2015-01-30 14:47:55 PST
New version of the patch will no longer causes any assertion hit in HashTable code.
Chris Dumez
Comment 9 2015-01-30 16:15:20 PST
Created attachment 245752 [details] Patch
Chris Dumez
Comment 10 2015-01-30 16:45:59 PST
Created attachment 245759 [details] Patch
WebKit Commit Bot
Comment 11 2015-01-30 17:39:27 PST
Comment on attachment 245759 [details] Patch Clearing flags on attachment: 245759 Committed r179431: <http://trac.webkit.org/changeset/179431>
WebKit Commit Bot
Comment 12 2015-01-30 17:39:32 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.