COMMIT_MESSAGE

 12011-01-31 Mario Sanchez Prada <msanchez@igalia.com>
 2
 3 Reviewed by NOBODY (OOPS!).
 4
 5 [Gtk] atk_text_set_caret_offset fails for list items
 6 https://bugs.webkit.org/show_bug.cgi?id=53388
 7
 8 Allow using text ranges across list items.
 9
 10 * accessibility/gtk/AccessibilityObjectAtk.cpp:
 11 (WebCore::AccessibilityObject::allowsTextRanges): Add list items
 12 to the list of accessibility objects supporting text ranges.
 13
 142011-01-31 Mario Sanchez Prada <msanchez@igalia.com>
 15
 16 Reviewed by NOBODY (OOPS!).
 17
 18 [Gtk] atk_text_set_caret_offset fails for list items
 19 https://bugs.webkit.org/show_bug.cgi?id=53388
 20
 21 Update unit test to check the fix for this bug.
 22
 23 * tests/testatk.c:
 24 (testWebkitAtkCaretOffsets): Ensure setting the caret in a list
 25 item through the AtkText interface is possible.

Source/WebCore/ChangeLog

22
33 Reviewed by NOBODY (OOPS!).
44
 5 [Gtk] atk_text_set_caret_offset fails for list items
 6 https://bugs.webkit.org/show_bug.cgi?id=53388
 7
 8 Allow using text ranges across list items.
 9
 10 * accessibility/gtk/AccessibilityObjectAtk.cpp:
 11 (WebCore::AccessibilityObject::allowsTextRanges): Add list items
 12 to the list of accessibility objects supporting text ranges.
 13
 142011-01-31 Mario Sanchez Prada <msanchez@igalia.com>
 15
 16 Reviewed by NOBODY (OOPS!).
 17
518 [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
619 https://bugs.webkit.org/show_bug.cgi?id=53389
720

Source/WebCore/accessibility/gtk/AccessibilityObjectAtk.cpp

@@void AccessibilityObject::setWrapper(AccessibilityObjectWrapper* wrapper)
105105
106106bool AccessibilityObject::allowsTextRanges() const
107107{
108  return isTextControl() || isWebArea() || isGroup() || isLink() || isHeading();
 108 return isTextControl() || isWebArea() || isGroup() || isLink() || isHeading() || isListItem();
109109}
110110
111111unsigned AccessibilityObject::getLengthForTextRange() const

Source/WebKit/gtk/ChangeLog

22
33 Reviewed by NOBODY (OOPS!).
44
 5 [Gtk] atk_text_set_caret_offset fails for list items
 6 https://bugs.webkit.org/show_bug.cgi?id=53388
 7
 8 Update unit test to check the fix for this bug.
 9
 10 * tests/testatk.c:
 11 (testWebkitAtkCaretOffsets): Ensure setting the caret in a list
 12 item through the AtkText interface is possible.
 13
 142011-01-31 Mario Sanchez Prada <msanchez@igalia.com>
 15
 16 Reviewed by NOBODY (OOPS!).
 17
518 [Gtk] atk_text_set_caret_offset returns True even when it is unsuccessful
619 https://bugs.webkit.org/show_bug.cgi?id=53389
720

Source/WebKit/gtk/tests/testatk.c

@@static void testWebkitAtkCaretOffsets()
292292 result = atk_text_set_caret_offset(ATK_TEXT(listItem), 1);
293293 g_assert_cmpint(result, ==, FALSE);
294294
295  /* TODO: Check here that it's possible to set the caret in the
296  middle of the text for a list item when fixing bug 53388.
297  https://bugs.webkit.org/show_bug.cgi?id=53388 */
 295 /* It should be possible to place the caret inside an item's text. */
 296 result = atk_text_set_caret_offset(ATK_TEXT(listItem), 5);
 297 g_assert_cmpint(result, ==, TRUE);
 298
 299 /* Uncomment the following two lines when fixing bug 53436. */
 300 /* offset = atk_text_get_caret_offset(ATK_TEXT(listItem)); */
 301 /* g_assert_cmpint(offset, ==, 5); */
298302
299303 AtkObject* panel = atk_object_ref_accessible_child(object, 3);
300304 g_assert(ATK_IS_OBJECT(panel));