ChangeLog

2012-08-06  Jon Lee  <jonlee@apple.com>

        Change Notification.permissionLevel() to Notification.permission

        https://bugs.webkit.org/show_bug.cgi?id=88919

        <rdar://problem/11650319>

        Reviewed by NOBODY (OOPS!).

        Retrieving the permission level has changed to Notification.permission, per this discussion:

        http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html

        Test: fast/notifications/notifications-permission.html

        * Modules/notifications/Notification.cpp: Rename to match attribute name.

        (WebCore::Notification::permission):

        * Modules/notifications/Notification.h: Rename to match attribute name.

        (Notification):

        * Modules/notifications/Notification.idl: Change to static readonly attribute.

2012-08-03  Kentaro Hara  <haraken@chromium.org>

        [V8] Remove v8StringToWebCoreString()

Source/WebCore/Modules/notifications/Notification.cpp

@@void Notification::taskTimerFired(Timer<Notification>* timer)

#if ENABLE(NOTIFICATIONS)

257 const String& Notification::permission~~Level~~(ScriptExecutionContext* context)

257const String& Notification::permission(ScriptExecutionContext* context)

{

    ASSERT(context->isDocument());

    ASSERT(static_cast<Document*>(context)->page());

Source/WebCore/Modules/notifications/Notification.h

@@public:

    void finalize();

#if ENABLE(NOTIFICATIONS)

141 static const String& permission~~Level~~(ScriptExecutionContext*);

141 static const String& permission(ScriptExecutionContext*);

    static const String& permissionString(NotificationClient::Permission);

    static void requestPermission(ScriptExecutionContext*, PassRefPtr<NotificationPermissionCallback>);

#endif

Source/WebCore/Modules/notifications/Notification.idl

@@module threads {

#if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS

55 [CallWith=ScriptExecutionContext] ~~static~~ DOMString permission~~Level()~~;

55 static readonly attribute [CallWith=ScriptExecutionContext] DOMString permission;

        [Custom] static void requestPermission(in NotificationPermissionCallback callback);

#endif

LayoutTests/ChangeLog

2012-08-06  Jon Lee  <jonlee@apple.com>

        Change Notification.permissionLevel() to Notification.permission

        https://bugs.webkit.org/show_bug.cgi?id=88919

        <rdar://problem/11650319>

        Reviewed by NOBODY (OOPS!).

        Derived from notifications-check-permission.html, using the new API.

        * fast/notifications/notifications-permission-expected.txt: Added.

        * fast/notifications/notifications-permission.html: Added.

2012-07-20  Jon Lee  <jonlee@apple.com>

        Crash in Notification when setting a non-object as an event listener (91881)

LayoutTests/fast/notifications/notifications-permission-expected.txt

Check for existence of Notification.permission

On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".

PASS window.Notification is defined.

PASS window.Notification.permission is defined.

PASS successfullyParsed is true

TEST COMPLETE

LayoutTests/fast/notifications/notifications-permission.html

<!DOCTYPE html>

<html>

<head>

	<script src="../js/resources/js-test-pre.js"></script>

</head>

<body>

<div id="description"></div>

<div id="console"></div>

<script type="text/javascript">

description("Check for existence of Notification.permission");

shouldBeDefined("window.Notification");

shouldBeDefined("window.Notification.permission");

var successfullyParsed = true;

</script>

<script src="../js/resources/js-test-post.js"></script>

</body>

</html>