Attachment #76883 for bug #51208

View Details Raw Unified Return to Bug 51208

| Differences between



2010-12-17  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by NOBODY (OOPS!).

        [Qt] GraphicsContext should respect QWebView render hints
        https://bugs.webkit.org/show_bug.cgi?id=51208

        Adjust the test since SmoothPixmapTransform is set by default.

        * tests/qwebview/tst_qwebview.cpp:
        (tst_QWebView::renderHints):

2010-12-05  Antonio Gomes  <agomes@rim.com>

        Reviewed by Ariya Hidayat.



{
    QWebView webView;

    // default is only text antialiasing + smooth pixmap transform
    QVERIFY(!(webView.renderHints() & QPainter::Antialiasing));
    QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);
    QVERIFY(webView.renderHints() & QPainter::SmoothPixmapTransform);
    QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));

    webView.setRenderHint(QPainter::Antialiasing, true);
    QVERIFY(webView.renderHints() & QPainter::Antialiasing);
    QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);
    QVERIFY(webView.renderHints() & QPainter::SmoothPixmapTransform);
    QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));

    webView.setRenderHint(QPainter::Antialiasing, false);
    QVERIFY(!(webView.renderHints() & QPainter::Antialiasing));
    QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);
    QVERIFY(webView.renderHints() & QPainter::SmoothPixmapTransform);
    QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));

    webView.setRenderHint(QPainter::SmoothPixmapTransform, true);

Return to Bug 51208

Lines 1-3 a/WebKit/qt/ChangeLog_sec1
- a/WebKit/qt/ChangeLog +12 lines
		1	2010-12-17 Ariya Hidayat <ariya@sencha.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	[Qt] GraphicsContext should respect QWebView render hints
		6	https://bugs.webkit.org/show_bug.cgi?id=51208
		7
		8	Adjust the test since SmoothPixmapTransform is set by default.
		9
		10	* tests/qwebview/tst_qwebview.cpp:
		11	(tst_QWebView::renderHints):
		12
1	2010-12-05 Antonio Gomes <agomes@rim.com>	13	2010-12-05 Antonio Gomes <agomes@rim.com>
2		14
3	Reviewed by Ariya Hidayat.	15	Reviewed by Ariya Hidayat.

Lines 79-100 void tst_QWebView::renderHints() a/WebKit/qt/tests/qwebview/tst_qwebview.cpp_sec1
- a/WebKit/qt/tests/qwebview/tst_qwebview.cpp -4 / +4 lines
79	{	79	{
80	QWebView webView;	80	QWebView webView;
81		81
82	// default is only text antialiasing	82	// default is only text antialiasing + smooth pixmap transform
83	QVERIFY(!(webView.renderHints() & QPainter::Antialiasing));	83	QVERIFY(!(webView.renderHints() & QPainter::Antialiasing));
84	QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);	84	QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);
85	QVERIFY(!(webView.renderHints() & QPainter::SmoothPixmapTransform));	85	QVERIFY(webView.renderHints() & QPainter::SmoothPixmapTransform);
86	QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));	86	QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));
87		87
88	webView.setRenderHint(QPainter::Antialiasing, true);	88	webView.setRenderHint(QPainter::Antialiasing, true);
89	QVERIFY(webView.renderHints() & QPainter::Antialiasing);	89	QVERIFY(webView.renderHints() & QPainter::Antialiasing);
90	QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);	90	QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);
91	QVERIFY(!(webView.renderHints() & QPainter::SmoothPixmapTransform));	91	QVERIFY(webView.renderHints() & QPainter::SmoothPixmapTransform);
92	QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));	92	QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));
93		93
94	webView.setRenderHint(QPainter::Antialiasing, false);	94	webView.setRenderHint(QPainter::Antialiasing, false);
95	QVERIFY(!(webView.renderHints() & QPainter::Antialiasing));	95	QVERIFY(!(webView.renderHints() & QPainter::Antialiasing));
96	QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);	96	QVERIFY(webView.renderHints() & QPainter::TextAntialiasing);
97	QVERIFY(!(webView.renderHints() & QPainter::SmoothPixmapTransform));	97	QVERIFY(webView.renderHints() & QPainter::SmoothPixmapTransform);
98	QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));	98	QVERIFY(!(webView.renderHints() & QPainter::HighQualityAntialiasing));
99		99
100	webView.setRenderHint(QPainter::SmoothPixmapTransform, true);	100	webView.setRenderHint(QPainter::SmoothPixmapTransform, true);