Attachment #73444 for bug #49230

View Details Raw Unified Return to Bug 49230

| Differences between



2010-11-09  Helder Correia  <helder@sencha.com>

        Reviewed by NOBODY (OOPS!).

        Philip Canvas test 2d.pattern.image.incomplete fails
        https://bugs.webkit.org/show_bug.cgi?id=49230

        Modidy test to correctly follow the spec and create an image object
        with its complete attribute set to false. See also:
        https://bugs.webkit.org/show_bug.cgi?id=48306

        * canvas/philip/tests/2d.pattern.image.incomplete.html:
        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt: Removed.
        * platform/qt/Skipped:

2010-11-09  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline.

Lines 13-18 a/LayoutTests/canvas/philip/tests/2d.pattern.image.incomplete.html_sec1
- a/LayoutTests/canvas/philip/tests/2d.pattern.image.incomplete.html +1 lines
13	_addTest(function(canvas, ctx) {	13	_addTest(function(canvas, ctx) {
14		14
15	var img = new Image();	15	var img = new Image();
		16	img.src = "NotARealFileName.png";
16	_assertSame(img.complete, false, "img.complete", "false");	17	_assertSame(img.complete, false, "img.complete", "false");
17	_assertSame(ctx.createPattern(img, 'repeat'), null, "ctx.createPattern(img, 'repeat')", "null");	18	_assertSame(ctx.createPattern(img, 'repeat'), null, "ctx.createPattern(img, 'repeat')", "null");
18		19

Lines 5338-5344 canvas/philip/tests/2d.path.arcTo.ensuresubpath.2.html a/LayoutTests/platform/gtk/Skipped_sec1
- a/LayoutTests/platform/gtk/Skipped -1 lines
5338	canvas/philip/tests/2d.path.clip.empty.html	5338	canvas/philip/tests/2d.path.clip.empty.html
5339	canvas/philip/tests/2d.path.rect.winding.html	5339	canvas/philip/tests/2d.path.rect.winding.html
5340	canvas/philip/tests/2d.pattern.image.broken.html	5340	canvas/philip/tests/2d.pattern.image.broken.html
5341	canvas/philip/tests/2d.pattern.image.incomplete.html
5342	canvas/philip/tests/2d.shadow.enable.blur.html	5341	canvas/philip/tests/2d.shadow.enable.blur.html
5343	canvas/philip/tests/2d.shadow.enable.x.html	5342	canvas/philip/tests/2d.shadow.enable.x.html
5344	canvas/philip/tests/2d.shadow.enable.y.html	5343	canvas/philip/tests/2d.shadow.enable.y.html

Lines 132-138 canvas/philip/tests/2d.path.arcTo.ensuresubpath.2.html a/LayoutTests/platform/mac-leopard/Skipped_sec1
- a/LayoutTests/platform/mac-leopard/Skipped -1 lines
132	canvas/philip/tests/2d.path.clip.empty.html	132	canvas/philip/tests/2d.path.clip.empty.html
133	canvas/philip/tests/2d.path.rect.winding.html	133	canvas/philip/tests/2d.path.rect.winding.html
134	canvas/philip/tests/2d.pattern.image.broken.html	134	canvas/philip/tests/2d.pattern.image.broken.html
135	canvas/philip/tests/2d.pattern.image.incomplete.html
136	canvas/philip/tests/2d.shadow.enable.blur.html	135	canvas/philip/tests/2d.shadow.enable.blur.html
137	canvas/philip/tests/2d.shadow.enable.x.html	136	canvas/philip/tests/2d.shadow.enable.x.html
138	canvas/philip/tests/2d.shadow.enable.y.html	137	canvas/philip/tests/2d.shadow.enable.y.html

Lines 1-2 a/LayoutTests/platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt_sec1
- a/LayoutTests/platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt -2 lines
1	Failed assertion img.complete === false (got true[boolean], expected false[boolean])
2	Failed assertion ctx.createPattern(img, 'repeat') === null (got [object CanvasPattern][object], expected [object])

Lines 5067-5073 canvas/philip/tests/2d.path.rect.winding.html a/LayoutTests/platform/qt/Skipped_sec1
- a/LayoutTests/platform/qt/Skipped -1 lines
5067	canvas/philip/tests/2d.path.rect.zero.6.html	5067	canvas/philip/tests/2d.path.rect.zero.6.html
5068	canvas/philip/tests/2d.path.stroke.scale2.html	5068	canvas/philip/tests/2d.path.stroke.scale2.html
5069	canvas/philip/tests/2d.pattern.image.broken.html	5069	canvas/philip/tests/2d.pattern.image.broken.html
5070	canvas/philip/tests/2d.pattern.image.incomplete.html
5071	canvas/philip/tests/2d.shadow.transform.2.html	5070	canvas/philip/tests/2d.shadow.transform.2.html
5072	canvas/philip/tests/2d.text.draw.baseline.bottom.html	5071	canvas/philip/tests/2d.text.draw.baseline.bottom.html
5073	canvas/philip/tests/2d.text.draw.baseline.hanging.html	5072	canvas/philip/tests/2d.text.draw.baseline.hanging.html

Return to Bug 49230

Lines 1-3 a/LayoutTests/ChangeLog_sec1
- a/LayoutTests/ChangeLog +17 lines
		1	2010-11-09 Helder Correia <helder@sencha.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	Philip Canvas test 2d.pattern.image.incomplete fails
		6	https://bugs.webkit.org/show_bug.cgi?id=49230
		7
		8	Modidy test to correctly follow the spec and create an image object
		9	with its complete attribute set to false. See also:
		10	https://bugs.webkit.org/show_bug.cgi?id=48306
		11
		12	* canvas/philip/tests/2d.pattern.image.incomplete.html:
		13	* platform/gtk/Skipped:
		14	* platform/mac-leopard/Skipped:
		15	* platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt: Removed.
		16	* platform/qt/Skipped:
		17
1	2010-11-09 Mihai Parparita <mihaip@chromium.org>	18	2010-11-09 Mihai Parparita <mihaip@chromium.org>
2		19
3	Unreviewed Chromium rebaseline.	20	Unreviewed Chromium rebaseline.