Attachment #42518 for bug #31140

View Details Raw Unified Return to Bug 31140

| Differences between



2009-11-04  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by NOBODY (OOPS!).

        [Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
        https://bugs.webkit.org/show_bug.cgi?id=31140

        QtNetwork interprets null string as request to remove the header, not add it.
        So if a header does not have a value, pass QtNetwork an empty string instead.

        * platform/network/qt/ResourceRequestQt.cpp:
        (WebCore::ResourceRequest::toNetworkRequest):

2009-11-04  Benjamin Otte  <otte@gnome.org>

        Reviewed by Gustavo Noronha.

Lines 41-47 WebCore/platform/network/qt/ResourceRequestQt.cpp_sec1
- WebCore/platform/network/qt/ResourceRequestQt.cpp -1 / +4 lines
41	it != end; ++it) {	41	it != end; ++it) {
42	QByteArray name = QString(it->first).toAscii();	42	QByteArray name = QString(it->first).toAscii();
43	QByteArray value = QString(it->second).toAscii();	43	QByteArray value = QString(it->second).toAscii();
44	request.setRawHeader(name, value);	44	if (!value.isNull())
		45	request.setRawHeader(name, value);
		46	else
		47	request.setRawHeader(name, "");
45	}	48	}
46		49
47	switch (cachePolicy()) {	50	switch (cachePolicy()) {

Return to Bug 31140

Lines 1-3 WebCore/ChangeLog_sec1
- WebCore/ChangeLog +13 lines
		1	2009-11-04 Yael Aharon <yael.aharon@nokia.com>
		2
		3	Reviewed by NOBODY (OOPS!).
		4
		5	[Qt] Allow setting HTTP headers with empty value in XMLHTTPRequest
		6	https://bugs.webkit.org/show_bug.cgi?id=31140
		7
		8	QtNetwork interprets null string as request to remove the header, not add it.
		9	So if a header does not have a value, pass QtNetwork an empty string instead.
		10
		11	* platform/network/qt/ResourceRequestQt.cpp:
		12	(WebCore::ResourceRequest::toNetworkRequest):
		13
1	2009-11-04 Benjamin Otte <otte@gnome.org>	14	2009-11-04 Benjamin Otte <otte@gnome.org>
2		15
3	Reviewed by Gustavo Noronha.	16	Reviewed by Gustavo Noronha.