Attachment #157245 for bug #92737

View Details Raw Unified Return to Bug 92737

| Differences between



2012-08-08  Iain Merrick  <husky@chromium.org>

        Enable kerning on Android
        https://bugs.webkit.org/show_bug.cgi?id=92737

        Reviewed by NOBODY (OOPS!).

        This #ifdef was incorrectly copied from our forked WebKit repository
        while unforking our Android-specific changes. Kerning works without
        any known problems.

        Testing: existing UI tests (not all unforked yet)

        * platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
        (WebCore::ComplexTextController::ComplexTextController):

2012-08-02  Alexander Pavlov  <apavlov@chromium.org>

        Web Inspector: Move DOM breakpoints-related context menu items into a submenu



    m_item.string = m_normalizedBuffer.get();
    m_item.stringLength = m_normalizedBufferLength;

#if OS(ANDROID)
    // Kerning does not currently work on Android.
    m_item.shaperFlags = HB_ShaperFlag_NoKerning;
#endif

    reset(startingX);
    m_startingY = startingY;


Return to Bug 92737

Lines 80-90 ComplexTextController::ComplexTextController(const Font* font, const TextRun& ru a/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp_sec1
- a/Source/WebCore/platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp -5 lines
80	m_item.string = m_normalizedBuffer.get();	80	m_item.string = m_normalizedBuffer.get();
81	m_item.stringLength = m_normalizedBufferLength;	81	m_item.stringLength = m_normalizedBufferLength;
82		82
83	#if OS(ANDROID)
84	// Kerning does not currently work on Android.
85	m_item.shaperFlags = HB_ShaperFlag_NoKerning;
86	#endif
87
88	reset(startingX);	83	reset(startingX);
89	m_startingY = startingY;	84	m_startingY = startingY;
90		85

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +16 lines
		1	2012-08-08 Iain Merrick <husky@chromium.org>
		2
		3	Enable kerning on Android
		4	https://bugs.webkit.org/show_bug.cgi?id=92737
		5
		6	Reviewed by NOBODY (OOPS!).
		7
		8	This #ifdef was incorrectly copied from our forked WebKit repository
		9	while unforking our Android-specific changes. Kerning works without
		10	any known problems.
		11
		12	Testing: existing UI tests (not all unforked yet)
		13
		14	* platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:
		15	(WebCore::ComplexTextController::ComplexTextController):
		16
1	2012-08-02 Alexander Pavlov <apavlov@chromium.org>	17	2012-08-02 Alexander Pavlov <apavlov@chromium.org>
2		18
3	Web Inspector: Move DOM breakpoints-related context menu items into a submenu	19	Web Inspector: Move DOM breakpoints-related context menu items into a submenu