Attachment #153288 for bug #88919

View Details Raw Unified Return to Bug 88919

| Differences between



2012-07-19  Jon Lee  <jonlee@apple.com>

        Change Notification.permissionLevel() to Notification.permission
        https://bugs.webkit.org/show_bug.cgi?id=88919
        <rdar://problem/11650319>

        Reviewed by NOBODY (OOPS!).

        Retrieving the permission level has changed to Notification.permission, per this discussion:
        http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html

        * Modules/notifications/Notification.cpp: Rename to match attribute name.
        (WebCore::Notification::permission):
        * Modules/notifications/Notification.h: Rename to match attribute name.
        (Notification):
        * Modules/notifications/Notification.idl: Change to static readonly attribute.
        * bindings/scripts/CodeGeneratorV8.pm: Alter generation script to ignore static attributes until
        static attributes are supported.
        (GenerateHeader):
        (GenerateImplementation):
        * bindings/scripts/test/TestObj.idl:

2012-07-17  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: show loaders memory consumption on the memory chart.

Lines 254-260 void Notification::taskTimerFired(Timer<Notification>* timer) a/Source/WebCore/Modules/notifications/Notification.cpp_sec1
- a/Source/WebCore/Modules/notifications/Notification.cpp -1 / +1 lines
254		254
255		255
256	#if ENABLE(NOTIFICATIONS)	256	#if ENABLE(NOTIFICATIONS)
257	const String& Notification::permissionLevel(ScriptExecutionContext* context)	257	const String& Notification::permission(ScriptExecutionContext* context)
258	{	258	{
259	ASSERT(context->isDocument());	259	ASSERT(context->isDocument());
260	ASSERT(static_cast<Document*>(context)->page());	260	ASSERT(static_cast<Document*>(context)->page());

Lines 138-144 public: a/Source/WebCore/Modules/notifications/Notification.h_sec1
- a/Source/WebCore/Modules/notifications/Notification.h -1 / +1 lines
138	void finalize();	138	void finalize();
139		139
140	#if ENABLE(NOTIFICATIONS)	140	#if ENABLE(NOTIFICATIONS)
141	static const String& permissionLevel(ScriptExecutionContext*);	141	static const String& permission(ScriptExecutionContext*);
142	static const String& permissionString(NotificationClient::Permission);	142	static const String& permissionString(NotificationClient::Permission);
143	static void requestPermission(ScriptExecutionContext*, PassRefPtr<NotificationPermissionCallback>);	143	static void requestPermission(ScriptExecutionContext*, PassRefPtr<NotificationPermissionCallback>);
144	#endif	144	#endif

Lines 52-58 module threads { a/Source/WebCore/Modules/notifications/Notification.idl_sec1
- a/Source/WebCore/Modules/notifications/Notification.idl -1 / +1 lines
52		52
53		53
54	#if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS	54	#if defined(ENABLE_NOTIFICATIONS) && ENABLE_NOTIFICATIONS
55	[CallWith=ScriptExecutionContext] static DOMString permissionLevel();	55	static readonly attribute DOMString permission;
56	[Custom] static void requestPermission(in NotificationPermissionCallback callback);	56	[Custom] static void requestPermission(in NotificationPermissionCallback callback);
57	#endif	57	#endif
58		58



    }

    foreach my $attribute (@{$dataNode->attributes}) {
        next if $attribute->isStatic;
        my $name = $attribute->signature->name;
        my $attrExt = $attribute->signature->extendedAttributes;
        my $conditionalString = $codeGenerator->GenerateConditionalString($attribute->signature);

    for (my $index = 0; $index < @{$dataNode->attributes}; $index++) {
        my $attribute = @{$dataNode->attributes}[$index];
        my $attrType = $attribute->signature->type;
        next if $attribute->isStatic;

        # Generate special code for the constructor attributes.
        if ($attrType =~ /Constructor$/) {

    my @enabledPerContext;
    my @normal;
    foreach my $attribute (@$attributes) {
        next if $attribute->isStatic;
        if ($interfaceName eq "DOMWindow" && $attribute->signature->extendedAttributes->{"V8Unforgeable"}) {
            push(@disallowsShadowing, $attribute);
        } elsif ($attribute->signature->extendedAttributes->{"V8EnabledAtRuntime"}) {

Lines 38-44 module test { a/Source/WebCore/bindings/scripts/test/TestObj.idl_sec1
- a/Source/WebCore/bindings/scripts/test/TestObj.idl -1 / +1 lines
38	readonly attribute long readOnlyIntAttr;	38	readonly attribute long readOnlyIntAttr;
39	readonly attribute DOMString readOnlyStringAttr;	39	readonly attribute DOMString readOnlyStringAttr;
40	readonly attribute TestObj readOnlyTestObjAttr;	40	readonly attribute TestObj readOnlyTestObjAttr;
41	#if defined(TESTING_JS)	41	#if defined(TESTING_JS) \|\| defined(TESTING_V8)
42	static readonly attribute long staticReadOnlyIntAttr;	42	static readonly attribute long staticReadOnlyIntAttr;
43	static attribute DOMString staticStringAttr;	43	static attribute DOMString staticStringAttr;
44	#endif	44	#endif

Return to Bug 88919

Lines 1-3 a/Source/WebCore/ChangeLog_sec1
- a/Source/WebCore/ChangeLog +22 lines
		1	2012-07-19 Jon Lee <jonlee@apple.com>
		2
		3	Change Notification.permissionLevel() to Notification.permission
		4	https://bugs.webkit.org/show_bug.cgi?id=88919
		5	<rdar://problem/11650319>
		6
		7	Reviewed by NOBODY (OOPS!).
		8
		9	Retrieving the permission level has changed to Notification.permission, per this discussion:
		10	http://lists.w3.org/Archives/Public/public-web-notification/2012Jun/0000.html
		11
		12	* Modules/notifications/Notification.cpp: Rename to match attribute name.
		13	(WebCore::Notification::permission):
		14	* Modules/notifications/Notification.h: Rename to match attribute name.
		15	(Notification):
		16	* Modules/notifications/Notification.idl: Change to static readonly attribute.
		17	* bindings/scripts/CodeGeneratorV8.pm: Alter generation script to ignore static attributes until
		18	static attributes are supported.
		19	(GenerateHeader):
		20	(GenerateImplementation):
		21	* bindings/scripts/test/TestObj.idl:
		22
1	2012-07-17 Ilya Tikhonovsky <loislo@chromium.org>	23	2012-07-17 Ilya Tikhonovsky <loislo@chromium.org>
2		24
3	Web Inspector: show loaders memory consumption on the memory chart.	25	Web Inspector: show loaders memory consumption on the memory chart.

Lines 436-441 END a/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm_sec1
- a/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm -1 / +3 lines
436	}	436	}
437		437
438	foreach my $attribute (@{$dataNode->attributes}) {	438	foreach my $attribute (@{$dataNode->attributes}) {
		439	next if $attribute->isStatic;
439	my $name = $attribute->signature->name;	440	my $name = $attribute->signature->name;
440	my $attrExt = $attribute->signature->extendedAttributes;	441	my $attrExt = $attribute->signature->extendedAttributes;
441	my $conditionalString = $codeGenerator->GenerateConditionalString($attribute->signature);	442	my $conditionalString = $codeGenerator->GenerateConditionalString($attribute->signature);
Lines 2506-2511 sub GenerateImplementation a/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm_sec2
2506	for (my $index = 0; $index < @{$dataNode->attributes}; $index++) {	2507	for (my $index = 0; $index < @{$dataNode->attributes}; $index++) {
2507	my $attribute = @{$dataNode->attributes}[$index];	2508	my $attribute = @{$dataNode->attributes}[$index];
2508	my $attrType = $attribute->signature->type;	2509	my $attrType = $attribute->signature->type;
		2510	next if $attribute->isStatic;
2509		2511
2510	# Generate special code for the constructor attributes.	2512	# Generate special code for the constructor attributes.
2511	if ($attrType =~ /Constructor$/) {	2513	if ($attrType =~ /Constructor$/) {
Lines 2595-2601 sub GenerateImplementation a/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm_sec3
2595	my @enabledPerContext;	2597	my @enabledPerContext;
2596	my @normal;	2598	my @normal;
2597	foreach my $attribute (@$attributes) {	2599	foreach my $attribute (@$attributes) {
2598		2600	next if $attribute->isStatic;
2599	if ($interfaceName eq "DOMWindow" && $attribute->signature->extendedAttributes->{"V8Unforgeable"}) {	2601	if ($interfaceName eq "DOMWindow" && $attribute->signature->extendedAttributes->{"V8Unforgeable"}) {
2600	push(@disallowsShadowing, $attribute);	2602	push(@disallowsShadowing, $attribute);
2601	} elsif ($attribute->signature->extendedAttributes->{"V8EnabledAtRuntime"}) {	2603	} elsif ($attribute->signature->extendedAttributes->{"V8EnabledAtRuntime"}) {